for all one's trouble

for (all) one's trouble

In exchange for the effort that one has made. Usually, the "reward" that such effort yields is negative. A: "But you've been so much better about getting to work on time!" B: "Yep, and all I got for my trouble was the boss criticizing my typing skills instead." And what did I get for all my trouble? A lousy commemorative pin.
See also: for, trouble
Farlex Dictionary of Idioms. © 2015 Farlex, Inc, all rights reserved.

for (all) one’s trouble

phr. in spite of one’s efforts; in very poor payment for one’s efforts. He got a punch in the jaw for all his trouble.
See also: all, for, trouble
McGraw-Hill's Dictionary of American Slang and Colloquial Expressions Copyright © 2006 by The McGraw-Hill Companies, Inc. All rights reserved.