for all (one's) (something)
In spite of the negative trait or issue the speaker is discussing. In this construction, the speaker indicates a specific person, followed by a problem or shortcoming they have experienced or exhibit. Yeah, she's not remotely punctual, and she gripes a lot, but for all her shortcomings, Elisa is a really great manager—her employees just love her. For all our difficulties buying a house, we still managed to get one that we absolutely love. A: "For all your complaining, I thought you guys had a terrible vacation." B: "Eh, it was fine in the end."
Farlex Dictionary of Idioms. © 2024 Farlex, Inc, all rights reserved.